[ovs-dev] [packet_in v2 05/18] pktbuf: Directly use pointers in pktbuf_save().
Ben Pfaff
blp at nicira.com
Sat Jan 7 20:41:15 UTC 2012
On Sat, Jan 07, 2012 at 11:11:46AM -0800, Ethan Jackson wrote:
> In future patches, directly using a void * pointer in the
> pktbuf_save() definition will simplify the code.
>
> Signed-off-by: Ethan Jackson <ethan at nicira.com>
In pktbuf_save(), you can use ofpbuf_clone_data_with_headroom() instead
of open-coding it.
I think there's an existing incorrect statement in the comment on
pktbuf_save(): 'in_port' should be an OpenFlow port number these days, I
think.
Otherwise it looks good. Thank you.
More information about the dev
mailing list