[ovs-dev] [packet_in v2 06/18] packets: Mask out CFI bit in eth_push_vlan().

Ben Pfaff blp at nicira.com
Sat Jan 7 20:45:01 UTC 2012


On Sat, Jan 07, 2012 at 11:11:47AM -0800, Ethan Jackson wrote:
> We should never push a VLAN tag with the CFI bit set.  This patch
> defensively enforces this invariant.

I see two callers that mask this bit out now-redundantly:

lib/dpif-netdev.c:            eth_push_vlan(packet, vlan->vlan_tci & ~htons(VLAN_CFI));
lib/flow.c:        eth_push_vlan(b, flow->vlan_tci & ~htons(VLAN_CFI));

Will you please fold in changes to stop them doing that?

Thanks,

Ben.



More information about the dev mailing list