[ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

Ben Pfaff blp at nicira.com
Fri Jan 13 00:21:17 UTC 2012


On Thu, Jan 12, 2012 at 11:40:00AM -0800, Ethan Jackson wrote:
> This commit makes the LACP unit tests more general by adding
> ovs-appctl bond/show output.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Hmm.  The "bond - single port" test is a bit paradoxical seeing as a
single port isn't a bond.  I guess it illustrates that LACP works with
a single port too.

You can write
        AT_CHECK([ovs-appctl bond/show], [0], [])
as
        AT_CHECK([ovs-appctl bond/show])
since those are the defaults anyway.

Otherwise looks good, thank you.



More information about the dev mailing list