[ovs-dev] [eviction 08/12] ofproto: Remove unnecessary assignment from ofoperation_complete().

Ethan Jackson ethan at nicira.com
Mon Jan 23 21:49:30 UTC 2012


Looks good.

Ethan

On Fri, Jan 13, 2012 at 16:43, Ben Pfaff <blp at nicira.com> wrote:
> Nothing uses op->victim following this assignment, so it is not
> needed.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  ofproto/ofproto.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index ff356f4..cc309b3 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -3297,7 +3297,6 @@ ofoperation_complete(struct ofoperation *op, enum ofperr error)
>             oftable_substitute_rule(rule, op->victim);
>             ofproto_rule_destroy__(rule);
>         }
> -        op->victim = NULL;
>         break;
>
>     case OFOPERATION_DELETE:
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list