[ovs-dev] [PATCH] stp: Log topology change events.

Ben Pfaff blp at nicira.com
Wed Jan 25 22:09:07 UTC 2012


On Wed, Jan 25, 2012 at 02:01:59PM -0800, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

I don't think that test-stp should use VLOG_DEFINE_THIS_MODULE,
because it doesn't log anything itself.

I think it would be more better for test-stp.c to just call
vlog_set_pattern() itself, rather than each use of it including it on
the command line.  You could also have it disable logging to syslog
with vlog_set_levels(), since that just makes the unit tests spam
syslog.  If you make those changes, then test-stp.c wouldn't need the
more sophisticated command-line parsing that you added; I am
indifferent whether you keep it or remove it.

Thanks,

Ben.



More information about the dev mailing list