[ovs-dev] [PATCH] ofproto: Fix typo in handle_nxt_set_packet_in_format().
Ben Pfaff
blp at nicira.com
Fri Jan 27 00:06:41 UTC 2012
Yeah, I was just reading code.
I pushed this, thanks.
On Thu, Jan 26, 2012 at 04:04:31PM -0800, Ethan Jackson wrote:
> Good catch thanks. Howd you notice this, just happened to be reading the code?
>
> Ethan
>
> On Thu, Jan 26, 2012 at 15:51, Ben Pfaff <blp at nicira.com> wrote:
> > NXFF_OPENFLOW10 and NXPIF_OPENFLOW10 have the same value (both zero), so
> > this doesn't fix an actual bug.
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > ofproto/ofproto.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> > index 0504026..7fa4eac 100644
> > --- a/ofproto/ofproto.c
> > +++ b/ofproto/ofproto.c
> > @@ -2880,7 +2880,7 @@ handle_nxt_set_packet_in_format(struct ofconn *ofconn,
> >
> > msg = (const struct nx_set_packet_in_format *) oh;
> > format = ntohl(msg->format);
> > - if (format != NXFF_OPENFLOW10 && format != NXPIF_NXM) {
> > + if (format != NXPIF_OPENFLOW10 && format != NXPIF_NXM) {
> > return OFPERR_OFPBRC_EPERM;
> > }
> >
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
More information about the dev
mailing list