[ovs-dev] [PATCH 2/2] vlog: Change the default timestamp structure.

Ben Pfaff blp at nicira.com
Fri Jan 27 20:04:05 UTC 2012


On Fri, Jan 27, 2012 at 11:39:15AM -0800, Gurucharan Shetty wrote:
> Change the default timestamp for console and file logs to
> UTC in a format that satisfies timestamp requirements in RFC 5424.
> 
> Also, add the ability for ovs-appctl to log timestamps in UTC.
> 
> Bug #9052.
> 
> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

This looks good.  I do have a few suggestions.

Please add an item to NEWS that mentions the new default log formats
and in particular that the timestamps are now in UTC by default.

Let's just drop the 'tm' parameter for ds_put_strftime().  No
caller passes a non-null value.

Thanks,

Ben.



More information about the dev mailing list