[ovs-dev] [RFC v4 00/63] Preliminary Open Flow 1.2 Message Support

Simon Horman horms at verge.net.au
Mon Jul 2 01:43:23 UTC 2012


On Fri, Jun 29, 2012 at 07:50:11PM +0900, Isaku Yamahata wrote:
> On Fri, Jun 29, 2012 at 01:41:31PM +0900, Isaku Yamahata wrote:
> > ../utilities/ovs-ofctl.c: In function 'do_show':
> > ../utilities/ovs-ofctl.c:500:63: warning: 'vconn' is used uninitialized in this function [-Wuninitialized]
> 
> 
> The following local hack is necessary to make ovs-ofctl work.
> At the moment, I'm not sure what version number should be sent at hello message.
> 
> diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> index f26356e..087e8f1 100644
> --- a/utilities/ovs-ofctl.c
> +++ b/utilities/ovs-ofctl.c
> @@ -497,7 +497,7 @@ do_show(int argc OVS_UNUSED, char *argv[])
>      struct ofpbuf *reply;
>      bool trunc;
>  
> -    make_openflow(sizeof(struct ofp_header), vconn_get_version(vconn),
> +    make_openflow(sizeof(struct ofp_header), OFP12_VERSION,
>                    OFPT_FEATURES_REQUEST, &request);
>      open_vconn(vconn_name, &vconn);

Thanks I think that OFP12_VERSION is correct here, so long
as Open Flow 1.2 is in use.

I think that an alternate fix is to move the open_vconn() call
to above the make_openflow() call. I think this relates to some
warnings that you posted, sorry for not looking into them yet.
I will do so shortly.



More information about the dev mailing list