[ovs-dev] [PATCH] netlink-socket: Do not assign netlink sequence number if it was already assigned when sending a message.

Atzm Watanabe atzm at stratosphere.co.jp
Thu Jul 5 07:55:52 UTC 2012


At Wed, 4 Jul 2012 23:01:40 -0700,
Ben Pfaff wrote:
> 
> On Thu, Jul 05, 2012 at 12:59:15PM +0900, Atzm Watanabe wrote:
> > Overwriting sequence number breaks replies (e.g. to brcompat).
> > 
> > Signed-off-by: Atzm Watanabe <atzm at stratosphere.co.jp>
> 
> Thanks for the patch.  I don't really like how it treats zero as a magic
> number (as far as I know, zero isn't special for nlmsg_seq), and how if
> some code sent the same ofpbuf twice it would use the same nlmsg_seq
> each time, so I sent out an alternative patch:
>         http://openvswitch.org/pipermail/dev/2012-July/018669.html
> But, I haven't tested it yet.  Does it work for you?

Thank you for your quick reply and work.
I've tested your patch and it works for me.

Regards,

Atzm.



More information about the dev mailing list