[ovs-dev] [bugs 1/4] ofproto: Fix compiler warnings.

[Ben Pfaff]

On Tue, Jul 17, 2012 at 09:28:06AM -0700, Ethan Jackson wrote:
> This patch fixes the following warnings on my system:
> 
> lib/ofp-actions.c:458:13: error: format '%x' expects argument of
> type 'unsigned int', but argument 4 has type 'long unsigned int'
> [-Werror=format]
> 
> ofproto/ofproto.c:3940:13: error: comparison between 'enum
> ofoperation_type' and 'enum nx_flow_update_event'
> [-Werror=enum-compare]
> 
> ofproto/ofproto.c:3941:13: error: comparison between 'enum
> ofoperation_type' and 'enum nx_flow_update_event'
> [-Werror=enum-compare]
> 
> ofproto/ofproto.c:3942:13: error: comparison between 'enum
> ofoperation_type' and 'enum nx_flow_update_event'
> [-Werror=enum-compare]
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Thanks for the fixes.

Here, %lx should be %zx (this is a size_t), so I made that change:
> -            VLOG_WARN("bad action format at offset %#x:\n%s",
> +            VLOG_WARN("bad action format at offset %#lx:\n%s",
>                        (n_in - left) * sizeof *a, ds_cstr(&s));
>              ds_destroy(&s);
>          }