[ovs-dev] Bug#682384: [PATCH] Fix race condition in parallel execution of "make install".

Ben Pfaff blp at nicira.com
Mon Jul 23 19:40:03 UTC 2012


Thanks.  I pushed this fix to master and branch-1.[87654].

On Mon, Jul 23, 2012 at 12:34:33PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
> 
> Ethan
> 
> On Mon, Jul 23, 2012 at 9:58 AM, Ben Pfaff <blp at nicira.com> wrote:
> > ovs-vsctl is listed, incorrectly, in both bin_PROGRAMS and bin_SCRIPTS.
> > This meant that "make install" with the -j option could try to install
> > ovs-vsctl two times in parallel, a race that occasionally caused a build
> > failure, e.g.:
> > http://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=s390&ver=1.4.2%2Bgit20120612-5&stamp=1342851603
> >
> > Debian bug #682384.
> > CC: 682384 at bugs.debian.org
> > Reported-by: Bastian Blank <waldi at debian.org>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > I already uploaded this to Debian as -6.  I'll wait for a review
> > before pushing it to the OVS repository.
> >
> >  utilities/automake.mk |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/utilities/automake.mk b/utilities/automake.mk
> > index 04a7fdc..7bb2c6d 100644
> > --- a/utilities/automake.mk
> > +++ b/utilities/automake.mk
> > @@ -4,7 +4,7 @@ bin_PROGRAMS += \
> >         utilities/ovs-dpctl \
> >         utilities/ovs-ofctl \
> >         utilities/ovs-vsctl
> > -bin_SCRIPTS += utilities/ovs-pki utilities/ovs-vsctl utilities/ovs-parse-leaks
> > +bin_SCRIPTS += utilities/ovs-pki utilities/ovs-parse-leaks
> >  if HAVE_PYTHON
> >  bin_SCRIPTS += \
> >         utilities/ovs-l3ping \
> > --
> > 1.7.2.5
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list