[ovs-dev] [PATCH 07/24] ofp-util: Make ofperr_encode_msg__() use correct Open Flow version

Ben Pfaff blp at nicira.com
Wed Jul 25 03:28:50 UTC 2012


On Wed, Jul 25, 2012 at 12:05:20PM +0900, Simon Horman wrote:
> On Wed, Jul 25, 2012 at 09:02:13AM +0900, Simon Horman wrote:
> > On Tue, Jul 24, 2012 at 01:37:35PM -0700, Ben Pfaff wrote:
> > > On Mon, Jul 23, 2012 at 03:16:36PM +0900, Simon Horman wrote:
> > > > Make ofperr_encode_msg__() use correct Open Flow version in the header
> > > > of messages.
> > > > 
> > > > Signed-off-by: Simon Horman <horms at verge.net.au>
> > > 
> > > Looks reasonable, thanks.  It doesn't apply cleanly on current master
> > > otherwise I'd just push it now.
> > > 
> > > Should we go a step further and eliminate struct ofperr_domain
> > > entirely from the public interface, using the OpenFlow version
> > > instead?
> > 
> > I think that could work out well, though I'm not entirely sure what
> > daemons may be lurking.
> 
> Here is the patch I cooked up.

Thanks!

> I have changed the ofperr_domain_from_version such that it uses
> NOT_REACHED() for unknown OF versions. This simplifies its callers
> (all in ofp-error.c) a little. I'm unsure what ill side effects it may have.

If you don't mind, please add that somewhere in the change log, and then
I'll be sure to carefully check that over when it comes up again in the
next iteration of the series.

Thanks,

Ben.



More information about the dev mailing list