[ovs-dev] [PATCH v3 05/12] ofp-actions: instruction decoder

Ben Pfaff blp at nicira.com
Wed Jul 25 04:22:28 UTC 2012


On Mon, Jul 23, 2012 at 05:08:44PM +0900, Isaku Yamahata wrote:
> Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp>

As far as I can tell, this doesn't delete the code at the end of
ofpacts_pull_openflow11_instructions() that signals an error on these
instructions:

    if (insts[OVSINST_OFPIT11_GOTO_TABLE] ||
        insts[OVSINST_OFPIT11_WRITE_METADATA] ||
        insts[OVSINST_OFPIT11_WRITE_ACTIONS] ||
        insts[OVSINST_OFPIT11_CLEAR_ACTIONS]) {
        error = OFPERR_OFPBIC_UNSUP_INST;
        goto exit;
    }

Is that intentional?



More information about the dev mailing list