[ovs-dev] [PATCH 03/24] nx-match: Separate raw match and header/pad pull/put

Ben Pfaff blp at nicira.com
Thu Jul 26 15:18:48 UTC 2012


On Thu, Jul 26, 2012 at 03:21:50PM +0900, Simon Horman wrote:
> On Tue, Jul 24, 2012 at 10:31:55PM -0700, Ben Pfaff wrote:
> > On Tue, Jul 24, 2012 at 10:47:20AM +0900, Simon Horman wrote:
> > > On Mon, Jul 23, 2012 at 03:16:32PM +0900, Simon Horman wrote:
> > > > In the case of Open Flow 1.2, which is currently the only
> > > > time that OXM is be used, there is a 4 byte header before
> > > > the match which needs to be taken into account when calculating
> > > > the pad length. This complicates nx_match pull and put somewhat.
> > > > 
> > > > This patch takes an approach suggested by Ben Pfaff to separate the
> > > > encoding of the match and the adding of padding and, in the case of OXM,
> > > > a header.
> > > > 
> > > > Signed-off-by: Simon Horman <horms at verge.net.au>
> > >
> > > I wonder if the cookie and cookie_mack parameters should be removed
> > > from oxm_pull_match(), oxm_pull_match_loose() and oxm_put_match() (below)
> > > as cookie is an NXM match that is not present in OXM.
> > 
> > That's probably reasonable, anybody who wants that feature can use NXM.
> 
> Thanks, I refreshed the patch and will include it in the next post of
> my OF1.2 series. For reference I now have the following.

Thanks, this looks good.



More information about the dev mailing list