[ovs-dev] bounce emailing Ed Maste

[Ben Pfaff]

Ed, I've had a couple of bounces of the following form emailing you.
I don't really know what to do about it so I'm forwarding it back to
the list in the hope that you'll see it.

Thanks,

Ben.

----- Forwarded message from Mail Delivery Subsystem <mailer-daemon at googlemail.com> -----

Date: Mon, 30 Jul 2012 16:58:07 +0000
From: Mail Delivery Subsystem <mailer-daemon at googlemail.com>
To: blp at nicira.com
Subject: Delivery Status Notification (Failure)

Delivery to the following recipient failed permanently:

     emaste at adaranet.com

Technical details of permanent failure: 
Google tried to deliver your message, but it was rejected by the recipient domain. We recommend contacting the other email provider for further information about the cause of this error. The error that the other server returned was: 550 550 Blocked (state 13).

----- Original message -----

X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent
         :x-gm-message-state;
        bh=F3fhca44oCS7o0g3DhUQ2eR1/4stmMdcjnU0P6/RooQ=;
        b=RV7oVgvX+yUr/FtRP0Q8Ad7n4NK0Z3RfaexXz01mmZ4PQrE/bM9zygpyhlDlPngGa9
         64E+kFj4dl+VX8HxQih/o/LpQe1yy8Y0m+qDZkVCBShrNCL2zUxNQQZdIWLb2PzTkXSX
         S692/zpE8M/3+DTs3RdYbl+fLlJE2X/XvcCgBcODlKE9dr7Z0kPhUOQHO9pOAmolO41N
         E+uWv5/AglMPQWLxhfobSV1Sfnv8hW/zNH+o1AUhdR+HVP28w1a/myFeRvTLJlUkdQcx
         65fA/LRFbacs2NzyFylVJ40CYqAy/5aFhGP3TAVqKxQufoSnyCFGhoM0am8Q3+L1/p2S
         p1MQ==
Received: by 10.68.197.202 with SMTP id iw10mr36278814pbc.161.1343667486993;
        Mon, 30 Jul 2012 09:58:06 -0700 (PDT)
Return-Path: <blp at nicira.com>
Received: from nicira.com (107-0-204-137-ip-static.hfc.comcastbusiness.net. [107.0.204.137])
        by mx.google.com with ESMTPS id ov6sm8244086pbb.41.2012.07.30.09.58.05
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 30 Jul 2012 09:58:05 -0700 (PDT)
Date: Mon, 30 Jul 2012 09:58:01 -0700
From: Ben Pfaff <blp at nicira.com>
To: Ed Maste <emaste at adaranet.com>
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] set_dscp failure on FreeBSD
Message-ID: <20120730165801.GD22988 at nicira.com>
References: <20120730154222.GA8702 at sandvine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120730154222.GA8702 at sandvine.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-Gm-Message-State: ALoCoQkInU2GLgBsNzHWvdh2yd1k6vtTI+t7Mephg39oEgPlIoUPjDf3oLaQboLHnT8zk23mEM2N

On Mon, Jul 30, 2012 at 03:42:22PM +0000, Ed Maste wrote:
> I'm working through a handful of unit test failures in the FreeBSD port
> and the first issue I've come across is set_dscp failing - as it turns
> out FreeBSD requires an int value for the setsockopt() call, not a char.
> 
> Looking at the Linux ip(7) man page I see the statement "TOS is a byte,"
> but all of the Linux code examples I've found in a quick Google search
> pass an int.
> 
> I made the change below to fix the issue on FreeBSD but would like some
> advice on whether it's suitable on Linux (or if I need some separate
> #ifdef'd code).

I remember looking at the manpage when set_dscp() was introduced and
seeing the advice that TOS was a byte, and then insisting that we
actually use a char there.

Now that I look at the Linux source, I see that it actually works OK
with either one (!):

		if (optlen >= sizeof(int)) {
			if (get_user(val, (int __user *) optval))
				return -EFAULT;
		} else if (optlen >= sizeof(char)) {
			unsigned char ucval;

			if (get_user(ucval, (unsigned char __user *) optval))
				return -EFAULT;
			val = (int) ucval;
		}

It's been like that as far back as 2.6.12 and probably farther, so no
historical baggage to worry about either.

IP_TOS doesn't appear to be in SUSv4, so there's no real "standard" to
rely on.

So: let's switch to using "int".  If you send a patch with the
changelog updated with the above information then I'll apply it.

Thanks,

Ben.

----- End forwarded message -----