[ovs-dev] [PATCH 1/2] dpif: Allow the port number to be requested when adding an interface.
Ben Pfaff
blp at nicira.com
Mon Jul 30 23:02:03 UTC 2012
On Sat, Jul 28, 2012 at 11:54:09AM -0700, Justin Pettit wrote:
> The datapath allows requesting a specific port number for a port, but
> the dpif interface didn't expose it. This commit adds that support.
>
> Signed-off-by: Justin Pettit <jpettit at nicira.com>
One oddity is that dpif_port_add() uses 0 as an out-of-band value for
input and UINT16_MAX as an out-of-band value for output. I think we
could use UINT16_MAX (or even 0) in both places, for a possibly less
confusing interface.
In dpif_port_add() don't we need to initialize port_no in the case
where port_nop is NULL?
Otherwise looks good, thanks.
More information about the dev
mailing list