[ovs-dev] [PATCH] Improving comment for OFP10_VLAN_NONE.

[Ben Pfaff]

On Mon, Jul 30, 2012 at 05:03:38PM -0700, Mehak Mahajan wrote:
> Signed-off-by: Mehak Mahajan <mmahajan at nicira.com>
> ---
>  include/openflow/openflow-1.0.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/openflow/openflow-1.0.h b/include/openflow/openflow-1.0.h
> index d71b007..97380fa 100644
> --- a/include/openflow/openflow-1.0.h
> +++ b/include/openflow/openflow-1.0.h
> @@ -362,7 +362,8 @@ enum ofp_flow_wildcards {
>  #define OFP_DL_TYPE_NOT_ETH_TYPE  0x05ff
>  
>  /* The VLAN id is 12-bits, so we can use the entire 16 bits to indicate
> - * special conditions.  All ones indicates that no VLAN id was set.
> + * special conditions.  All ones indicates that no VLAN id or PCP was set
> + * effectively indicating that 802.1Q header is not present.
>   */
>  #define OFP10_VLAN_NONE      0xffff

How about just "All ones indicates that no 802.1Q header is present."
since that really what it means.

Thanks,

Ben.