[ovs-dev] [PATCH 2/2] ovs-dpctl: Allow requesting the port number from "add-if" command.

Justin Pettit jpettit at nicira.com
Tue Jul 31 03:57:21 UTC 2012


On Jul 30, 2012, at 7:35 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Mon, Jul 30, 2012 at 06:45:51PM -0700, Justin Pettit wrote:
>> 
>> Thanks.  Based on your suggestion in the previous patch to use
>> UINT16_MAX instead of 0, I've updated this patch accordingly.
> 
> I don't want 65535 to be a part of the documented interface, because
> we'll probably adopt 32-bit port numbers some day and then we'll have to
> make some kind of awkward change.  So I hope you didn't document that
> 65535 means "pick one yourself".

No, I had completely dropped the reference to the magic number in the man page.  The only reason I had previously documented it was that I thought people might try to use port 0, and then be surprised.

Thanks for the reviews.  I pushed the series.

--Justin





More information about the dev mailing list