[ovs-dev] [PATCH 02/45] ofproto: As of Open Flow 1.1 switch_features has no capabilities field

Simon Horman horms at verge.net.au
Tue Jul 31 05:16:13 UTC 2012


On Mon, Jul 30, 2012 at 09:38:40PM -0700, Ben Pfaff wrote:
> On Mon, Jul 30, 2012 at 09:36:53PM -0700, Ben Pfaff wrote:
> > On Mon, Jul 30, 2012 at 11:03:00AM +0900, Simon Horman wrote:
> > > In Open Flow 1.0 switch_features has a capabilities field.
> > > However, in Open Flow 1.1, 1.2 and 1.3 this field is reserved.
> > > Thus it should not be read on decode and it seems most appropriate
> > > to set as zero on encode.
> > > 
> > > This patch takes the approach of setting the features field to
> > > all available features for Open Flow 1.1+. I am unsure if it would
> > > be sufficient to just set it to zero.
> > > 
> > > Signed-off-bu: Simon Horman <horms at verge.net.au>
> > 
> > s/bu/by here.
> > 
> > Let's just set it to zero on decode, do you mind making that change?
> 
> Scratch that, I'll just make a note to change that later.

Sure, that is fine too.



More information about the dev mailing list