[ovs-dev] [bpdu 2/4] packets: Generalize reserved RSPAN protocols.
Ethan Jackson
ethan at nicira.com
Thu Jun 7 01:22:36 UTC 2012
> Seems reasonable. Should we mention this in NEWS?
I think it makes sense to mention it in the next patch.
I added this:
- Additional protocols are not mirrored and dropped when forward-bpdu is
false. For a full list, see the ovs-vswitchd.conf.db man page.
>
> I'd mark the following structure "const" also:
>> + static struct masked_eth_addr mea[] = {
>> + { /* STP, IEEE pause frames, and other reserved protocols. */
>> + {0x01, 0x08, 0xc2, 0x00, 0x00, 0x00},
>> + {0xff, 0xff, 0xff, 0xff, 0xff, 0xf0}},
>> +
>
> Otherwise looks good, thank you.
More information about the dev
mailing list