[ovs-dev] FW: MPLS and VLAN QinQ patch

[Ben Pfaff]

On Tue, Jun 12, 2012 at 11:40:22AM -0700, ravi kerur wrote:
> On Tue, Jun 12, 2012 at 11:11 AM, Ben Pfaff <blp at nicira.com> wrote:
> > Ravi, I'm more or less happy with the userspace code here.  I mostly
> > have style kinds of concerns.  (I haven't fully scrutinized every line
> > though.)
> >
> 
> <rk> is it coding style or logic or something else?

Just coding style.

> > I did notice that compose_dec_mpls_ttl() decrements "ttl" twice (it
> > has --ttl in two places).
> 
> <rk> will look into it, probably they are ctx->flow and ctx->base_flow
> will double check.

Both are the same local variable.