[ovs-dev] [of1.1 rollup 01/20] openflow-1.1.h: Fix OFPFW11_* definitions.

[Ben Pfaff]

On Wed, Jun 13, 2012 at 10:37:17AM +0900, Simon Horman wrote:
> On Tue, Jun 12, 2012 at 06:25:40PM -0700, Ben Pfaff wrote:
> > On Wed, Jun 13, 2012 at 09:35:14AM +0900, Simon Horman wrote:
> > > On Tue, Jun 12, 2012 at 12:32:05AM -0700, Ben Pfaff wrote:
> > > > OFPFW_DL_SRC and OFPFW_DL_DST don't exist in OpenFlow 1.1.  Replace them
> > > > by the correct enums.
> > > > 
> > > > Most of the change here is due to respacing since DL_VLAN_PCP is one
> > > > character wider than any previous name.
> > > > 
> > > > This doesn't fix a real bug because these constants didn't have any users
> > > > in the tree.
> > > 
> > > Follow-up patch for Open Flow 1.2:
> > > 
> > > From: Simon Horman <horms at verge.net.au>
> > > 
> > > openflow-1.2.h Add OFPFW12_* definitions.
> > 
> > OpenFlow 1.2 uses OXM, which doesn't have wildcard flags, so I don't
> > understand the followup patch.
> 
> Sorry, I noticed the definitions in the spec, that is all.

Do you mean in Appendix B, section B.6.1?  That's reporting a change
that was made in OpenFlow 0.8.9.  The definitions there are no longer
relevant.

(It is confusing, now that I notice it.)

> Please drop this patch.

Will do.