[ovs-dev] [smap 1/3] bridge: Simplify VLAN splinter memory management.

[Ethan Jackson]

I did when I wrote it originally a couple of weeks ago, but I haven't
recently.  I'll try it again before merging.

Ethan

On Wed, Jun 13, 2012 at 9:30 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Jun 13, 2012 at 06:12:15PM -0700, Ethan Jackson wrote:
>> Before this patch, the VLAN splinter memory management operated on
>> blocks of memory instead of ovsrec_ports.  This strategy is
>> problematic in future patches when more than simply calling
>> 'free()' needs to be done to destroy splinter ports.  This patch
>> solves the problem by keeping track of entire ovsrec_ports instead
>> of just the memory allocated to create them.
>>
>> Signed-off-by: Ethan Jackson <ethan at nicira.com>
>
> It looks good at first read.  Did you try it out with VLAN splinters
> configured and verify that there are no memory leaks and no double-frees
> (e.g. with valgrind)?
>
> Thanks,
>
> Ben.