[ovs-dev] [PATCH] No need to restart DB / OVS on changing dscp value.

Ben Pfaff blp at nicira.com
Tue Jun 19 16:12:46 UTC 2012


On Fri, Jun 08, 2012 at 12:04:14PM -0700, Mehak Mahajan wrote:
> With this change there is no need to restart the DB or OVS on configuring a
> different value for the manager or controller connection respectively. On
> detecting a change in the dscp value on the socket, the previous socket is
> closed and a new socket is created and connection is established with the new
> configured dscp value.
> 
> Signed-off-by: Mehak Mahajan <mmahajan at nicira.com>

"git am" say:

    Applying: No need to restart DB / OVS on changing dscp value.
    /home/blp/ovs/.git/rebase-apply/patch:94: trailing whitespace.
            between the manager and the Open vSwitch.  If no value is specified, a 
    warning: 1 line adds whitespace errors.

A line in jsonrpc_session_set_dscp() is not indented correctly.

The assignment in jsonrpc_session_set_dscp() may be moved inside the
'if' block.

The parameter of rconn_get_dscp() may be declared 'const'.

Otherwise this looks good.  Thank you!



More information about the dev mailing list