[ovs-dev] [PATCH 1/3] ofproto: Add coverage for port additions and deletions.

Ethan Jackson ethan at nicira.com
Fri Jun 22 01:51:32 UTC 2012


Since port additions and deletions can be very expensive, it makes
sense to keep coverage for them.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
---
 ofproto/ofproto.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 38430ab..18f9b3c 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -63,6 +63,8 @@ COVERAGE_DEFINE(ofproto_recv_openflow);
 COVERAGE_DEFINE(ofproto_reinit_ports);
 COVERAGE_DEFINE(ofproto_uninstallable);
 COVERAGE_DEFINE(ofproto_update_port);
+COVERAGE_DEFINE(ofproto_port_add);
+COVERAGE_DEFINE(ofproto_port_del);
 
 enum ofproto_state {
     S_OPENFLOW,                 /* Processing OpenFlow commands. */
@@ -1319,6 +1321,7 @@ ofproto_port_add(struct ofproto *ofproto, struct netdev *netdev,
     uint16_t ofp_port;
     int error;
 
+    COVERAGE_INC(ofproto_port_add);
     error = ofproto->ofproto_class->port_add(ofproto, netdev, &ofp_port);
     if (!error) {
         update_port(ofproto, netdev_get_name(netdev));
@@ -1357,6 +1360,7 @@ ofproto_port_del(struct ofproto *ofproto, uint16_t ofp_port)
     const char *name = ofport ? netdev_get_name(ofport->netdev) : "<unknown>";
     int error;
 
+    COVERAGE_INC(ofproto_port_del)
     error = ofproto->ofproto_class->port_del(ofproto, ofp_port);
     if (!error && ofport) {
         /* 'name' is the netdev's name and update_port() is going to close the
-- 
1.7.10.2




More information about the dev mailing list