[ovs-dev] [PATCH] Setting miss_send_len on receiving NXT_SET_ASYNC_CONFIG message.
Ben Pfaff
blp at nicira.com
Tue Jun 26 03:26:08 UTC 2012
On Mon, Jun 25, 2012 at 05:17:28PM -0700, Mehak Mahajan wrote:
> For the service controllers to receive any asynchronous messages, the
> miss_send_len must be set to a non-zero value (refer to DESIGN). On
> receiving the NXT_SET_ASYNC_CONFIG message, the miss_send_len is set
> to the default value unless it is set to a non-zero value earlier by
> the OFPT_SET_CONFIG message.
>
> Signed-off-by: Mehak Mahajan <mmahajan at nicira.com>
[...]
> + if ((ofconn_get_type(ofconn) == OFCONN_SERVICE) &&
> + !ofconn_get_miss_send_len(ofconn)) {
> + ofconn_set_miss_send_len(ofconn, OFP_DEFAULT_MISS_SEND_LEN);
> + }
You don't need the extra (...) around the == test.
Otherwise, thanks, this looks good, assuming it passes the unit tests.
More information about the dev
mailing list