[ovs-dev] [PATCH 2/2] Adds parsing of OpenFlow 1.1+ Metadata

Ben Pfaff blp at nicira.com
Thu Jun 28 17:50:41 UTC 2012


On Thu, Jun 28, 2012 at 02:16:50PM +1200, Joe Stringer wrote:
> Related -- I've been looking into implementing OFPIT_WRITE_METADATA on
> top of your work at git://benpfaff.org/openvswitch on the of1.1
> branch, and I have some related thoughts.
> 
> So, with the above patch, I have used reg_load to load (fully-masked)
> metadata. Am I correct in understanding that reg_load only supports
> masking a sequential set of bits with an offset?
> 
> With write-metadata, it seems that we'll be seeking to be able to
> write metadata with an arbitrary mask, where the bits to be modified
> are defined, such that (new_metadata = old_metadata &  ̃mask | value &
> mask). Does it make sense to follow a path similar to NXM_NX_TUN_ID,
> creating a seperate structure and methods for the set_metadata action?
> 
> I was thinking that with the above approach, the
> ofpacts_pull_openflow11_instructions(...) would then put a
> set_metadata action into the ofpbuf.

The approach of adding a "set_metadata" action make sense.  That's the
path that I would follow.



More information about the dev mailing list