[ovs-dev] [unixctl_py 5/6] python: Add ovs_error() helper function to Python.

Ben Pfaff blp at nicira.com
Fri Mar 2 01:15:01 UTC 2012


On Thu, Mar 01, 2012 at 04:30:37PM -0800, Ethan Jackson wrote:
> The ovs_error() and ovs_fatal() helper functions are useful enough
> to be ported to Python.  A user will be added in a future commit.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Looks good to me.

In the final case in ovs_retval_to_string(), I think I'd use %s
instead of %d: maybe some non-integer value got passed in and my
instinct is that it's probably better to convert it to a string than
to throw an exception.



More information about the dev mailing list