[ovs-dev] Bug#659685: Bug#659685: Can we have a fix please?

[Simon Horman]

On Wed, Mar 07, 2012 at 04:48:55PM +0800, Thomas Goirand wrote:
> Hi,
> 
> I had a look to the current packaging of openvswitch, in order to fix
> this bug (eg: #659685) With all due respect... it's a mess.
> 
> The only reason why you are using Quilt is to patch files that are in
> your openvswitch_<version>.debian.tar.gz. Please don't abuse quilt like
> this! There's no reason to patch things under the debian folder, it
> should come already patched.
> 
> Your debian-changes-1.4.0-2 is reverting some of the patches previously
> applied, and which would have otherwise let the DKMS module.
> 
> I have attached a patch which removes all patches in debian/patches,
> since they aren't needed at all. Also, with this patch,
> openvswitch-datapath-dkms works as expected (eg: it build the kernel
> module), because using ${kernel_source_dir} as it should be. Please
> apply this patch and upload a new 1.4.0-3 of openvswitch.

Hi Thomas,

It is my understanding that placing patches under debian/patches is part of
the 3.0 (quilt) package format. Is OVS using the format incorrectly in some
way? Does that format interact with DKMS poorly in some way?