[ovs-dev] [PATCH v2] datapath: Fix checksum update for actions on UDP packets.

Ben Pfaff blp at nicira.com
Wed Mar 7 18:46:36 UTC 2012


On Tue, Mar 06, 2012 at 03:40:51PM -0800, Jesse Gross wrote:
> When modifying IP addresses or ports on a UDP packet we don't
> correctly follow the rules for unchecksummed packets.  This meant
> that packets without a checksum can be given a incorrect new checksum
> and packets with a checksum can become marked as being unchecksummed.
> This fixes it to handle those requirements.
> 
> Bug #8937
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>
> ---
> v2: CSUM_MANGLED_0 was not introduced until 2.6.20

It's not obvious to me why the UDP cases in this file need a check for
OVS_CSUM_PARTIAL but the TCP cases do not.

It would make the naming more consistent if this patch also renamed
set_tcp_port() to set_tcp().

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list