[ovs-dev] [PATCH 1/5] netdev-linux: Use get-stats to check status of linux devices.

Ben Pfaff blp at nicira.com
Wed Mar 7 18:51:31 UTC 2012


On Wed, Mar 07, 2012 at 10:42:47AM -0800, Pravin Shelar wrote:
> On Wed, Mar 7, 2012 at 9:57 AM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Mar 06, 2012 at 02:37:02PM -0800, Pravin B Shelar wrote:
> >> Rather than using ETHTOOL_GDRVINFO to check netdev-status, use
> >> ovs-get-stats since it is more consistent. Covergage counter is
> >> added for status check.
> >>
> >> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
> >
> > In netdev_linux_get_status(), I don't understand why we want to return
> > vport_stats_error.  We know that we have driver info at that point, so
> > why not just return 0?  It would save a system call.
> >
> I thought netdev_get_status() call need to check status explicitly
> every time. If that is not the case, I will remove call to get status.

I do not think that it is necessary.  If the vport has gone away, we
will find out by other means soon enough.

Thanks,

Ben.



More information about the dev mailing list