[ovs-dev] [unixctl 2/2] unixctl: Timeout unit tests instead of hanging.

Ethan Jackson ethan at nicira.com
Wed Mar 7 20:51:23 UTC 2012


Thanks, I've removed the redundant double [] and merged this to master.

Ethan

On Wed, Mar 7, 2012 at 12:45, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Mar 06, 2012 at 05:53:08PM -0800, Ethan Jackson wrote:
>> We've seen some unixctl tests hang indefinitely which makes them
>> difficult to debug.  ovs-appctl and appctl.py calls to timeout
>> instead.
>>
>> Signed-off-by: Ethan Jackson <ethan at nicira.com>
>
> I don't see any reason to double the [] in the definitions here:
>> +m4_define([APPCTL], [[ovs-appctl --timeout 20]])
>> +m4_define([PYAPPCTL], [[$PYTHON $srcdir/appctl.py --timeout 20]])
>
> Otherwise, seems reasonable to me, thank you.



More information about the dev mailing list