[ovs-dev] [PATCH v3 1/6] netdev-linux: Cache drv-info for net device.

[Ben Pfaff]

On Fri, Mar 09, 2012 at 12:02:16PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v2-v3:
>      - Dont issue ETHTOOL_GDRVINFO for internal devices.
>      - Discard drv-info on RTM_DELLINK event.
> v1-v2:
>      - Added comment for netdev_internal_open.
>      - Removed get-stat call from status check.
> 
> --8<--------------------------cut here-------------------------->8--
> 
> Netdev-linux calls ETHTOOL_GDRVINFO on every netdev_linux_get_status()
> which is not optimal as drv-info does not change for given device.
> So following patch changes netdev_linux_get_status() to read drv-info at
> device initialization and cache it.
> 
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

Seems fine.  One comment:

> +static int
> +netdev_internal_get_status(const struct netdev *netdev OVS_UNUSED, struct shash *sh)
> +{
> +    shash_add(sh, "driver_name", xstrdup("Openvswitch"));
> +    return 0;
> +}

The kernel driver uses "openvswitch", in all lowercase, so we should
probably use the same capitalization here for consistency.

Thanks,

Ben.