[ovs-dev] [PATCH] tests: Fix "make check" as non-root.

[Ben Pfaff]

On Mon, Mar 12, 2012 at 10:28:40AM -0700, Ben Pfaff wrote:
> On Mon, Mar 12, 2012 at 10:28:09AM -0700, Chris Wright wrote:
> > * Ben Pfaff (blp at nicira.com) wrote:
> > > On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> > > > * Ben Pfaff (blp at nicira.com) wrote:
> > > > > Without this change, these tests try to write to /var/run, which fails
> > > > > unless "make check" is run as root.
> > > > 
> > > > Yay!  This was breaking for me on Friday too.
> > > > 
> > > > I'm still hitting this from make distcheck (haven't dug into it yet):
> > > > 
> > > > mv ovsdb/ovsdb-server.1.tmp ovsdb/ovsdb-server.1
> > > > printf '\043 Generated automatically -- do not modify!    -*- buffer-read-only: t -*-\n' > ../python/ovs/version.py.tmp
> > > > /bin/sh: ../python/ovs/version.py.tmp: Permission denied
> > > > make[3]: *** [../python/ovs/version.py] Error 1
> > > 
> > > Oh, that sort of thing.  I'll send out a fix.
> > 
> > Cool, this bit as well:
> > 
> > ERROR: files left in build directory after distclean:
> > ./include/openflow/openflow-1.0.hstamp
> > ./include/openflow/openflow-1.1.hstamp
> > ./include/openflow/openflow.hstamp
> > make[1]: *** [distcleancheck] Error 1
> 
> Yeah, I see that too.  I think I just need to add them to CLEANFILES.

I sent out "distcheck" fixes.