[ovs-dev] [PATCH] ofproto: Optimize set_internal_devs_mtu()

[Ben Pfaff]

On Fri, Mar 09, 2012 at 02:32:42PM -0800, Pravin B Shelar wrote:
> Internal device mtu does not influence mtu of other internal devices.
> So skip MTU setting completely when internal device mtu is changed.
> 
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

But won't this change behavior?  The internal device MTU is supposed
to be the least of any non-internal vport MTU.  Before this commit, I
think that we maintained that invariant; after this commit, it looks
like the administrator is allowed to change the internal device MTUs
to whatever he wants, except that if any other port changes then we
change them all back.

While scrutinizing the code I think I saw a bug in the original code.
I'll send a patch.