[ovs-dev] [PATCH] netdev-linux: Fix use-after-free when netdev_dump_queues() deletes queues.

Ben Pfaff blp at nicira.com
Mon Mar 19 20:51:51 UTC 2012


On Mon, Mar 19, 2012 at 01:45:21PM -0700, Ethan Jackson wrote:
> > +    HMAP_FOR_EACH_SAFE (queue, next_queue, hmap_node, &netdev_dev->tc->queues) {
> 
> This line is one character too long.

It seems that my editor window was one character too wide.

Thanks, I fixed this.

> This looks good to me.  netdev_linux_dump_queues() has kind of a funny
> name considering that it really is a generic queue iterator.  I don't
> think this is the patch to fix it though.

What's a better name?



More information about the dev mailing list