[ovs-dev] [PATCH] datapath: fix lock up issue in ovs_vport_cmd_set()

Ansis Atteka aatteka at nicira.com
Thu Mar 22 00:13:35 UTC 2012


If ovs_vport_cmd_build_info() function failed inside
ovs_vport_cmd_set() then the rtnl lock must be released.

Signed-off-by: Ansis Atteka <aatteka at nicira.com>
---
 datapath/datapath.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/datapath/datapath.c b/datapath/datapath.c
index d64fc32..aa5be89 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -1885,7 +1885,7 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info)
 		err = PTR_ERR(reply);
 		netlink_set_err(GENL_SOCK(sock_net(skb->sk)), 0,
 				ovs_dp_vport_multicast_group.id, err);
-		return 0;
+		goto exit_unlock;
 	}
 
 	genl_notify(reply, genl_info_net(info), info->snd_pid,
-- 
1.7.9




More information about the dev mailing list