[ovs-dev] [PATCH] datapath: fix lock up issue in ovs_vport_cmd_set()

[Jesse Gross]

On Wed, Mar 21, 2012 at 5:13 PM, Ansis Atteka <aatteka at nicira.com> wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index d64fc32..aa5be89 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1885,7 +1885,7 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info)
>                err = PTR_ERR(reply);
>                netlink_set_err(GENL_SOCK(sock_net(skb->sk)), 0,
>                                ovs_dp_vport_multicast_group.id, err);
> -               return 0;
> +               goto exit_unlock;

This has a side effect of changing the error code from 0 to -ENOMEM
(presumably that's why building the message failed), which I don't
think is right because the actual command succeeded.  This is
obviously related to the other problem that you noticed with sending
messages on failure but we should try to avoid introducing side
effects in this patch.