[ovs-dev] [PATCH] Allow configuring DSCP on controller and manager connections.

Justin Pettit jpettit at nicira.com
Tue Mar 27 01:02:32 UTC 2012


On Mar 26, 2012, at 3:42 PM, Ben Pfaff wrote:

> On Fri, Mar 23, 2012 at 11:20:17PM -0700, Justin Pettit wrote:
>> By the way, when Mehak and I were resolving the conflicts, we found
>> that Ethan's IDL changes caused a somewhat subtle issue. The
>> "vswitch-idl.{c|h}" files were sticking around in the "vswitchd"
>> directory, which has a higher preference than the new "lib"
>> directory. Since the location is different, a "make clean" won't
>> delete the old files. If you're doing builds, you may want to clean
>> out those files in "vswitchd".
> 
> I don't understand this description.  What's a preference?

I meant to say "precedence".  The include path was choosing "vswitchd" before "lib", so it was always pulling the old one.  Since "vswitch-idl.h" was no longer in "vswitchd", "make clean" would just blow away the one in "lib".  Another issue was that even when "vswitchd/vswitch-idl.h" was removed, it would be recreated on the next call to "make".

Ethan and I were talking, and we wondered if it would make sense to continue to erase those "vswitchd/vswitch-idl.*" files when "make clean" is run for a little while.

--Justin





More information about the dev mailing list