[ovs-dev] [of1.2 errors 4/4] Add error codes for Open Flow v1.2

Ben Pfaff blp at nicira.com
Tue Mar 27 16:20:42 UTC 2012


On Tue, Mar 27, 2012 at 10:23:38AM +0900, Simon Horman wrote:
> On Mon, Mar 26, 2012 at 01:59:20PM -0700, Ben Pfaff wrote:
> > From: Simon Horman <horms at verge.net.au>
> > 
> > * Where Open Flow 1.2 breaks apart error codes defined
> >   in previous versions, provide all new definitions to
> >   previous versions and map the numeric error code to
> >   the first first definition supplied in ofp-errors.h.
> >   The case handled so far is:
> >   OFPERR_OFPBIC_BAD_EXP_TYPE -> { OFPERR_OFPBIC_BAD_EXPERIMENTER,
> >                                   OFPERR_OFPBIC_BAD_EXP_TYPE }
> > 
> > * Where Open Flow 1.2 adds error codes that were previously
> >   defined as Nicira extension errors define the later in terms
> >   of the new codes.
> > 
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> > [blp at nicira.com added better error checking in extract-ofp-errors, added
> >  unit tests, miscellaneous cleanup]
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Hi Ben,
> 
> this looks much more robust than my attempt. Ack.

Thank you for the reviews.  I pushed this series to master.

Would you mind rebasing and re-sending the rest of the series?  This
one only supplants patch 1 out of your series.



More information about the dev mailing list