[ovs-dev] [PATCH 4/4] Definitions for Open Flow 1.2

Ben Pfaff blp at nicira.com
Thu Mar 29 16:10:59 UTC 2012


On Thu, Mar 29, 2012 at 01:09:52PM +0900, Simon Horman wrote:
> On Wed, Mar 28, 2012 at 12:34:53PM -0700, Ben Pfaff wrote:
> > I don't think experimenter stats are actually different in 1.1 and
> > 1.2, although the sections are worded differently.
> 
> It seems to me that ofp11_experimenter_stats_header might look like this:
> 
> struct ofp11_experimenter_stats_header {
>     ovs_be32 experimenter;    /* Experimenter ID which takes the same form
>                                  as in struct ofp_experimenter_header. */
>     /* Experimenter-defined arbitrary additional data. */
> };
> OFP_ASSERT(sizeof(struct ofp11_experimenter_stats_header) == 4);
> 
> Whereas ofp12_experimenter_stats_header explicitly includes a four
> byte exp_type after the experimenter.

I suppose that's some kind of difference.  It matches the existing
format of all the stats extensions that Nicira ever added, FWIW.

OK, leave it in, maybe it'll be useful someday.



More information about the dev mailing list