[ovs-dev] [leaks 3/5] tests: Suppress valgrind error reports from glibc timer_create() function.

Ethan Jackson ethan at nicira.com
Thu Mar 29 19:16:05 UTC 2012


> Wow this is annoying.  Seems like a reasonable solution to the
> problem.  Looks good.

Actually come to think of it, does it make sense to upstream something
like this to valgrind?

Ethan


>
> Ethan
>
> On Wed, Mar 28, 2012 at 14:58, Ben Pfaff <blp at nicira.com> wrote:
>> valgrind reports a memory leak and a parameter error in glibc's
>> timer_create() in almost every program execution.  I don't know a way to
>> avoid them.
>>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
>> ---
>>  tests/automake.mk |    3 ++-
>>  tests/glibc.supp  |   16 ++++++++++++++++
>>  2 files changed, 18 insertions(+), 1 deletions(-)
>>  create mode 100644 tests/glibc.supp
>>
>> diff --git a/tests/automake.mk b/tests/automake.mk
>> index 62f0c49..784ae9c 100644
>> --- a/tests/automake.mk
>> +++ b/tests/automake.mk
>> @@ -189,8 +189,9 @@ CLEANFILES += $(valgrind_wrappers)
>>  EXTRA_DIST += tests/valgrind-wrapper.in
>>
>>  VALGRIND = valgrind --log-file=valgrind.%p --leak-check=full \
>> +       --suppressions=$(abs_top_srcdir)/tests/glibc.supp \
>>        --suppressions=$(abs_top_srcdir)/tests/openssl.supp --num-callers=20
>> -EXTRA_DIST += tests/openssl.supp
>> +EXTRA_DIST += tests/glibc.supp tests/openssl.supp
>>  check-valgrind: all tests/atconfig tests/atlocal $(TESTSUITE) $(valgrind_wrappers)
>>        $(SHELL) '$(TESTSUITE)' -C tests CHECK_VALGRIND=true VALGRIND='$(VALGRIND)' AUTOTEST_PATH='tests/valgrind:$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS)
>>        @echo
>> diff --git a/tests/glibc.supp b/tests/glibc.supp
>> new file mode 100644
>> index 0000000..52d17bc
>> --- /dev/null
>> +++ b/tests/glibc.supp
>> @@ -0,0 +1,16 @@
>> +# suppress what appear to unavoidable error reports from glibc
>> +
>> +{
>> +   timer_create
>> +   Memcheck:Leak
>> +   fun:malloc
>> +   fun:timer_create
>> +}
>> +
>> +{
>> +   timer_create
>> +   Memcheck:Param
>> +   timer_create(evp)
>> +   fun:timer_create
>> +}
>> +
>> --
>> 1.7.2.5
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list