[ovs-dev] [PATCH] ofproto: Rate-limit STP status errors on non-existent ports.

Justin Pettit jpettit at nicira.com
Wed May 2 17:49:10 UTC 2012


As part of the bridge's main loop, it queries the STP status of all
ports.  If the port doesn't exist, log files can become filled with
warning messages.  This situation is very unusual, since system devices
do not normally disappear, but it's easy enough to rate-limit these
messages.

Bug #10936

Reported-by: Reid Price <reid at nicira.com>
Signed-off-by: Justin Pettit <jpettit at nicira.com>
---
 ofproto/ofproto.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index cb46d26..6ef2a5d 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -664,8 +664,8 @@ ofproto_port_get_stp_status(struct ofproto *ofproto, uint16_t ofp_port,
 {
     struct ofport *ofport = ofproto_get_port(ofproto, ofp_port);
     if (!ofport) {
-        VLOG_WARN("%s: cannot get STP status on nonexistent port %"PRIu16,
-                  ofproto->name, ofp_port);
+        VLOG_WARN_RL(&rl, "%s: cannot get STP status on nonexistent "
+                     "port %"PRIu16, ofproto->name, ofp_port);
         return ENODEV;
     }
 
-- 
1.7.5.4




More information about the dev mailing list