[ovs-dev] [PATCH 2/5] ofproto: Add support for OF1.3 port description multipart message.

[Ben Pfaff]

On Tue, May 08, 2012 at 09:24:31AM -0700, Justin Pettit wrote:
> On May 8, 2012, at 6:43 AM, Ben Pfaff wrote:
> 
> > I'd add a new-line before the first port, so that the formatting looks
> > the same for each port.
> 
> This seems like a general issue with the way we print messages.  For example:
> 
>     OFPT_FEATURES_REPLY (xid=0x1): dpid:0000505400000001
>     n_tables:2, n_buffers:256
>     capabilities: FLOW_STATS TABLE_STATS PORT_STATS ARP_MATCH_IP
> 
> Do you think we should just always start the body on a separate
> line?  Obviously, this would be disruptive to scripts that expect a
> certain format.  Alternatively, I can just add a newline in
> ofp_print_ofpst_port_desc_reply() before calling
> ofp_print_phy_ports().

I was thinking of it particularly here because it's a repeating data
format.  Every record (port) has the same visual format, except for
the first, which looks odd; it can seem like the first line of the
first record is missing if you look quickly.

> I realized that I didn't add a NEWS items, so I'm planning to add
> the following:

Sounds good.