[ovs-dev] [PATCHv2] ovs-ofctl: Use port description stat to look up ports when necessary.

Ben Pfaff blp at nicira.com
Tue May 8 17:47:01 UTC 2012


On Tue, May 08, 2012 at 10:42:11AM -0700, Justin Pettit wrote:
> Not all ports may fit in a Features Reply, so if that's the case, then
> use the new port description stat message for looking up ports.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

All I noticed is that in fetch_port_by_stats() we should check that
the reply is actually a port_desc stats reply (perhaps with
ofputil_decode_msg_type()), since right now AFAICT it will try to
interpret an error reply as a stats reply, which probably will work
out badly.

Thanks,

Ben.



More information about the dev mailing list