[ovs-dev] Issue with dpif_netdev_class not properly destroying datapaths
Ben Pfaff
blp at nicira.com
Fri May 11 16:52:14 UTC 2012
On Fri, May 11, 2012 at 09:52:16AM +0200, Giuseppe Lettieri wrote:
> Il 10/05/2012 18:32, Ben Pfaff ha scritto:
> > Hmm. This does sound like the correct pattern for a fix, but will it
> > cause OVS to delete tap devices that it didn't create? If not, then
> > it definitely sounds right to me.
>
> Good question. It causes OVS to close the fd. [...]
OK, I guess I assumed that more than that was necessary. The
nonpersistence of tap devices by default saves us here. Thanks.
> > Will you submit the patch to be included in upstream OVS? I'd
> > appreciate that.
>
> Sure, it is in attachment.
Thank you very much. The patch looks good and all the unit tests
pass.
Will you give me a Signed-off-by: line for this, for example:
Signed-off-by: Giuseppe Lettieri <g.lettieri at iet.unipi.it>
By doing this, you are agreeing to the Developer's Certificate of Origin
(see below for more details).
Developer's Certificate of Origin
---------------------------------
To help track the author of a patch as well as the submission chain,
and be clear that the developer has authority to submit a patch for
inclusion in openvswitch please sign off your work. The sign off
certifies the following:
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
More information about the dev
mailing list