[ovs-dev] [minor cleanups 1/5] ofproto: Remove write-only variable.

Ethan Jackson ethan at nicira.com
Mon May 14 18:04:11 UTC 2012


Looks good, thanks.

Ethan

On Sun, May 13, 2012 at 4:58 PM, Ben Pfaff <blp at nicira.com> wrote:
> Found by clang.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  ofproto/ofproto.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 98bb912..60dd36a 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -3227,14 +3227,13 @@ handle_nxt_set_controller_id(struct ofconn *ofconn,
>  static enum ofperr
>  handle_barrier_request(struct ofconn *ofconn, const struct ofp_header *oh)
>  {
> -    struct ofp_header *ob;
>     struct ofpbuf *buf;
>
>     if (ofconn_has_pending_opgroups(ofconn)) {
>         return OFPROTO_POSTPONE;
>     }
>
> -    ob = make_openflow_xid(sizeof *ob, OFPT10_BARRIER_REPLY, oh->xid, &buf);
> +    make_openflow_xid(sizeof *oh, OFPT10_BARRIER_REPLY, oh->xid, &buf);
>     ofconn_send_reply(ofconn, buf);
>     return 0;
>  }
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list