[ovs-dev] [PATCH] vswitch.xml: Suggest secure fail-mode to avoid loops with multiple uplinks.

[Ben Pfaff]

I pushed this commit.  I'm still waiting for feedback on the second
one.

On Thu, May 10, 2012 at 03:17:04PM -0700, Justin Pettit wrote:
> Looks good.
> 
> In the line above your change, should we just state what the default
> is?  I remember we used to not want to put OVS's defaults into the
> OVSDB spec.  However, we now do put our defaults in, so I think it
> would be clearer if we just go ahead and do it for this one, too.
> 
> --Justin
> 
> 
> On May 10, 2012, at 10:11 AM, Ben Pfaff wrote:
> 
> > EXT-186.
> > Reported-by: Rob Sherwood <rob.sherwood at bigswitch.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > AUTHORS              |    1 +
> > vswitchd/vswitch.xml |    6 ++++++
> > 2 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/AUTHORS b/AUTHORS
> > index 89472b3..2ff4e2d 100644
> > --- a/AUTHORS
> > +++ b/AUTHORS
> > @@ -135,6 +135,7 @@ Peter Balland           peter at nicira.com
> > Peter Phaal             peter.phaal at inmon.com
> > Ram Jothikumar          rjothikumar at nicira.com
> > Ramana Reddy            gtvrreddy at gmail.com
> > +Rob Sherwood            rob.sherwood at bigswitch.com
> > Roger Leigh             rleigh at codelibre.net
> > Rogério Vinhal Nunes
> > Sean Brady              sbrady at gtfservices.com
> > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> > index b9b7b97..308af51 100644
> > --- a/vswitchd/vswitch.xml
> > +++ b/vswitchd/vswitch.xml
> > @@ -410,6 +410,12 @@
> >         </dl>
> >         </p>
> >         <p>If this value is unset, the default is implementation-specific.</p>
> > +        <p>
> > +          The <code>standalone</code> mode can create forwarding loops on a
> > +          bridge that has more than one uplink port unless STP is enabled.  To
> > +          avoid loops on such a bridge, configure <code>secure</code> mode or
> > +          enable STP (see <ref column="stp_enable"/>).
> > +        </p>
> >         <p>When more than one controller is configured,
> >         <ref column="fail_mode"/> is considered only when none of the
> >         configured controllers can be contacted.</p>
> > -- 
> > 1.7.2.5
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>