[ovs-dev] [PATCH] vswitch.xml: Suggest secure fail-mode to avoid loops with multiple uplinks.
Ben Pfaff
blp at nicira.com
Wed May 16 19:38:23 UTC 2012
Thanks, I pushed this documentation-only change.
I'm not a strong supporter of either default, but changing the default
is likely to break people's setups (even though we do not say what the
default is in the install). Therefore I suggest that if we are going
to change the default, we document that we're going to change it and
start logging a warning when the fail-mode is not explicitly set, and
then only actually change it a couple of versions later.
On Mon, May 14, 2012 at 09:23:03PM -0700, Justin Pettit wrote:
> Looks good to me.
>
> I wasn't volunteering that we'd change the default. There was a
> suggestion that OpenFlow 1.0.1 forbid standalone support. I said
> that we would most likely not follow that, since not only do we
> support that mode, it's our default. I suggested we might be open
> to changing the default, but I'd check to see what other's thought.
>
> --Justin
>
>
> On May 14, 2012, at 2:12 PM, Ben Pfaff wrote:
>
> > I pushed this commit. I'm still waiting for feedback on the second
> > one.
> >
> > On Thu, May 10, 2012 at 03:17:04PM -0700, Justin Pettit wrote:
> >> Looks good.
> >>
> >> In the line above your change, should we just state what the default
> >> is? I remember we used to not want to put OVS's defaults into the
> >> OVSDB spec. However, we now do put our defaults in, so I think it
> >> would be clearer if we just go ahead and do it for this one, too.
> >>
> >> --Justin
> >>
> >>
> >> On May 10, 2012, at 10:11 AM, Ben Pfaff wrote:
> >>
> >>> EXT-186.
> >>> Reported-by: Rob Sherwood <rob.sherwood at bigswitch.com>
> >>> Signed-off-by: Ben Pfaff <blp at nicira.com>
> >>> ---
> >>> AUTHORS | 1 +
> >>> vswitchd/vswitch.xml | 6 ++++++
> >>> 2 files changed, 7 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/AUTHORS b/AUTHORS
> >>> index 89472b3..2ff4e2d 100644
> >>> --- a/AUTHORS
> >>> +++ b/AUTHORS
> >>> @@ -135,6 +135,7 @@ Peter Balland peter at nicira.com
> >>> Peter Phaal peter.phaal at inmon.com
> >>> Ram Jothikumar rjothikumar at nicira.com
> >>> Ramana Reddy gtvrreddy at gmail.com
> >>> +Rob Sherwood rob.sherwood at bigswitch.com
> >>> Roger Leigh rleigh at codelibre.net
> >>> Rogério Vinhal Nunes
> >>> Sean Brady sbrady at gtfservices.com
> >>> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> >>> index b9b7b97..308af51 100644
> >>> --- a/vswitchd/vswitch.xml
> >>> +++ b/vswitchd/vswitch.xml
> >>> @@ -410,6 +410,12 @@
> >>> </dl>
> >>> </p>
> >>> <p>If this value is unset, the default is implementation-specific.</p>
> >>> + <p>
> >>> + The <code>standalone</code> mode can create forwarding loops on a
> >>> + bridge that has more than one uplink port unless STP is enabled. To
> >>> + avoid loops on such a bridge, configure <code>secure</code> mode or
> >>> + enable STP (see <ref column="stp_enable"/>).
> >>> + </p>
> >>> <p>When more than one controller is configured,
> >>> <ref column="fail_mode"/> is considered only when none of the
> >>> configured controllers can be contacted.</p>
> >>> --
> >>> 1.7.2.5
> >>>
> >>> _______________________________________________
> >>> dev mailing list
> >>> dev at openvswitch.org
> >>> http://openvswitch.org/mailman/listinfo/dev
> >>
>
More information about the dev
mailing list