[ovs-dev] [PATCH] odp-util: Update ODPUTIL_FLOW_KEY_BYTES for current kernel flow format.

[Ben Pfaff]

On Wed, May 16, 2012 at 12:38:17PM -0700, Jesse Gross wrote:
> On Wed, May 16, 2012 at 12:30 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, May 15, 2012 at 03:51:02PM -0700, Jesse Gross wrote:
> >> It looks correct to me.  I would like it if we had a more automated
> >> way to compute this (even beyond the unit test that you added) since
> >> we have run into this problem a couple times now but this is clearly
> >> an improvement.
> >
> > Yeah, I'd like that too, but I don't see a good way to do it.  Even if
> > I wrote a program or script to sum up the sizes of all the possible
> > fields, this wouldn't be enough, since some of the fields can repeat.
> 
> I don't have a good way to exercise it either.  One alternative would
> be to dynamically allocate the memory in cases where we don't have
> enough space.  It's not optimal but it's probably better than
> crashing.

That's a good idea.  I'll make a note to do that.